Fix drive sequence number #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guga31bb
approved these changes
Aug 30, 2023
|
hooray fixed a 2 year old issue |
I was actually about to add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #309
We have this issue #309 with 2013 postseason games where the driveSequenceNumber in the plays df is NA for all plays. That prevents drive information from being joined.
In this case, we compute our own driveSequenceNumber by incrementing a counter depending on the value of driveTimeOfPossession. driveTimeOfPossession will be a constant value during a drive so this should actually be accurate